As it stands today, if no_change_count++ isn't > 10, we will reset it to 0. There's no way to get above 1 (let alone 10) so this isn't working as intended. If we see progress (last_forkoff != tbstat.bs_forkoff) *then* we sould reset the no_change_count counter to 0. Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- fsr/xfs_fsr.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c index b5aa3db..5eaabb5 100644 --- a/fsr/xfs_fsr.c +++ b/fsr/xfs_fsr.c @@ -1099,8 +1099,8 @@ fsr_setup_attr_fork( if (last_forkoff == tbstat.bs_forkoff) { if (no_change_cnt++ > 10) break; - } - no_change_cnt = 0; + } else /* progress! */ + no_change_cnt = 0; last_forkoff = tbstat.bs_forkoff; /* work out which way to grow the fork */ -- 1.7.1 _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs