On 12/08/12 06:08, Christoph Hellwig wrote:
There is no reason to conditionally take the iolock inside xfs_setattr_size when we can let the caller handle it unconditionally, which just incrases the lock hold time for the case where it was previously taken internally by a few instructions. Signed-off-by: Christoph Hellwig<hch@xxxxxx> --- fs/xfs/xfs_file.c | 2 +- fs/xfs/xfs_iops.c | 28 +++++++++++++++------------- fs/xfs/xfs_vnodeops.c | 3 +-- fs/xfs/xfs_vnodeops.h | 2 +- 4 files changed, 18 insertions(+), 17 deletions(-)
looks good Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
