Re: [PATCH] xfstests: Change the interpreter of ltp/runtest.sh to bash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Satoru,

On Mon, Dec 10, 2012 at 08:37:41AM +0900, Satoru Takeuchi wrote:
> From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
> 
> In some environment, Running 080 fails with the following log.
> 
> ==========
> 080	 [failed, exit status 2] - output mismatch (see 080.out.bad)
> --- 080.out	2012-11-18 20:26:40.000000000 +0900
> +++ 080.out.bad	2012-12-08 21:05:15.000000000 +0900
> @@ -1,3 +1,26 @@
>  QA output created by 080
> 
> -Completed rwtest pass 1 successfully.
> +/home/sat/src/xfstests/ltp/rwtest.sh: 90: /home/sat/src/xfstests/ltp/rwtest.sh: 6: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 177: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 190: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +dirname: invalid option -- 'q'
> +Try `dirname --help' for more information.
> +/home/sat/src/xfstests/ltp/rwtest.sh: 270: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 317: /home/sat/src/xfstests/ltp/rwtest.sh: F[0+1]=-q: not found
> +dirname: invalid option -- 'c'
> +Try `dirname --help' for more information.
> +/home/sat/src/xfstests/ltp/rwtest.sh: 270: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 317: /home/sat/src/xfstests/ltp/rwtest.sh: F[0+1]=-c: not found
> +dirname: invalid option -- 'i'
> +Try `dirname --help' for more information.
> +/home/sat/src/xfstests/ltp/rwtest.sh: 270: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 317: /home/sat/src/xfstests/ltp/rwtest.sh: F[0+1]=-i: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 270: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 317: /home/sat/src/xfstests/ltp/rwtest.sh: F[0+1]=2000: not found
> +dirname: invalid option -- 'f'
> +Try `dirname --help' for more information.
> +/home/sat/src/xfstests/ltp/rwtest.sh: 270: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 317: /home/sat/src/xfstests/ltp/rwtest.sh: F[0+1]=-f: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 270: /home/sat/src/xfstests/ltp/rwtest.sh: [[: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 317: /home/sat/src/xfstests/ltp/rwtest.sh: F[0+1]=direct,buffered,sync: not found
> +/home/sat/src/xfstests/ltp/rwtest.sh: 320: /home/sat/src/xfstests/ltp/rwtest.sh: Bad substitution
> ==========
> 
> It happens because ltp/rwtest.sh assumes /bin/sh is `bash' and it's not
> always true (ex. /bin/sh is `dash' in Debian.) This script should
> explicitly declare that its interpriter is `bash'.
> 
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.  I cleaned up the commit header a little bit.

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux