Hi Ben, On 01/08/2013 09:03 PM, Ben Myers wrote: > Hey Abhijit, > > On Tue, Jan 08, 2013 at 08:45:10PM +0530, Abhijit Pawar wrote: >> On 01/08/2013 12:51 PM, Jeff Liu wrote: >>> On 01/08/2013 04:49 AM, Ben Myers wrote: >>>> On Sun, Jan 06, 2013 at 11:50:08AM +0800, Jeff Liu wrote: >>>>> This small patch convert xfs_parseargs() and suffix_strtoul() to >>>>> use kstrtoint() instead of simple_strtoul() which is deprecated. >>>> >>>> It looks like Jeff's patch will conflict with a patch from Abhijit Pawar, 'fs: >>>> remove obsolete simple_strto<foo>' which we saw Dec 7. You guys went after the >>>> same thing and came up with slightly differing results. If Abhijit would >>>> prefer to factor out the xfs changes I'd be happy to take either that, or >>>> Jeff's patch, but it would be better if they didn't conflict. Can y'all come >>>> to an agreement as to what the xfs changes should be? >>> >>> Sorry, I missed that patch from Abhijit. >>> >>> Looks the previous patch did not replaced the simple_strtoul() with >>> kstrtoint() in suffix_strtoul(). >>> >>> Abhijit, would you like to fix it as well? >> >> Yes,it did not replace the call. Looks like I have missed that piece of >> code. Once Ben applies my original patch, I will send another patch for >> this on top of that. > > I believe that your original patch contains changes for other > filesystems too. I'd prefer to pull only xfs changes into the xfs branch. Are > you willing to factor out the xfs changes, add the suffix_strtoul, and resend? > That way we can get it done in one go. Yes. the patch contains changes to other filesystems as well. I will separate out the xfs changes in a new patch and will also fix the suffix_strtoul. I will send the patch soon. > > Regards, > Ben > -- - Abhijit _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
