On 12/12/12 5:16 PM, Dave Chinner wrote: > On Wed, Dec 12, 2012 at 04:46:20PM -0600, Eric Sandeen wrote: >> blkid_get_topology() ignores devices which report 512 >> as their minimum & optimal IO size, but we should ignore >> anything up to the physical block size; otherwise >> 4k devices will report a "stripe size" of 4k, and warn >> if anything larger is specified: > > As i read this, I thought no, that's wrong, it should read > "we should ignore anything up to the sector size". I had to read the > code to find out that's exactly what the change does. > > Perhaps you should be talking about sector sizes here? > >> - * If the reported values are just the normal 512 byte block size >> - * do not bother to report anything. It will just causes warnings >> - * if people specifier larger stripe units or widths manually. >> + * If the reported values are the same as the physical block size > > "... same as the sector size of the device ...." > > Otherwise seems sane... > > Cheers, > > Dave. > Sorry, yeah, s/block/sector/ I blame the meds (and hch's prior comment) ;) Will resend. -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
