Re: [3.0-stable PATCH 27/36] xfs: protect xfs_sync_worker with s_umount semaphore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 03, 2012 at 05:42:35PM -0600, Mark Tinguely wrote:
> From: Ben Myers <bpm@xxxxxxx>
> 
> Upstream commit: 1307bbd2af67283131728637e9489002adb26f10
> 
> xfs_sync_worker checks the MS_ACTIVE flag in s_flags to avoid doing
> work during mount and unmount.  This flag can be cleared by unmount
> after the xfs_sync_worker checks it but before the work is completed.
> The has caused crashes in the completion handler for the dummy
> transaction commited by xfs_sync_worker:

This doesn't belong in a stable kernel. It was wrong when it was
originally committed, it's wrong to backport it.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux