On Mon, Dec 03, 2012 at 05:42:25PM -0600, Mark Tinguely wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Upstream commit: d3bc815afb549eecb3679a4b2f0df216e34df998 > > When a partial write inside EOF fails, it can leave delayed > allocation blocks lying around because they don't get punched back > out. This leads to assert failures like: > > XFS: Assertion failed: XFS_FORCED_SHUTDOWN(ip->i_mount) || ip->i_delayed_blks == 0, file: fs/xfs/linux-2.6/xfs_super.c, line: 847 This is something that makes me worried. It's complex enough that I've forgotten all the nasty little things it took to get this right when I originally wrote it, and we have very little test coverage/verification of this error case in xfstests. Did you do anything other than run xfstests to verify this code is working properly? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
