On 11/27/12 4:11 PM, Christoph Hellwig wrote: > On Tue, Nov 27, 2012 at 03:16:39PM -0600, Eric Sandeen wrote: >> TBH, I don't know if this is posix-specified, but I found out the >> hard way that when trying to re-create existing files on a readonly >> filesystem, some apps expect/handle EEXIST, but fail on EROFS. >> >> This will test mkdir, mknod, and symlinks for that behavior. > > Just curious, which filesystem would fail this currently or did in the > past? No single filesystem, really - I temporarily broke the VFS in a rhel backport. ;) But it seems like the kind of thing that could be missed in the future, so figured it was worth a quick test. (basically this was from moving mnt_want_write outside i_mutex for freeze work, and returning an error directly from mnt_want_write() would give us EROFS instead of maybe EEXIST) -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs