On Wed, Nov 14, 2012 at 05:42:47PM +1100, Dave Chinner wrote: > xfs: remove xfs_tosspages > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > It's a buggy, unnecessary wrapper that is duplicating > truncate_pagecache_range(). > > When replacing the call in xfs_change_file_space(), also ensure that > the length being allocated/freed is always positive before making > any changes. These checks are done in the lower extent manipulation > functions, too, but we need to do them before any page cache > operations. > > Reported-by: Andrew Dahl <adahl@xxxxxxx> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good as long as Andrews fix is included. I wonder if we should just fix the two places with checks for easy backportability in a first patch and then have a second on top to kill the useless wrapper? Either way, Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
