On Mon, Nov 12, 2012 at 10:54:11PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > In preparation for verifying dir2 block format buffers, factor > the read operations out of the block operations (lookup, addname, > getdents) and some of the additional logic to make it easier to > understand an dmodify the code. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> This was a difficult review. I think you have at least three ideas in here which could be split up. Please keep the reviewer in mind. Reviewed-by: Ben Myers <bpm@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs