On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote: > On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: > >> Hi, > >> > >> Please, take a look. > >> > >> Patch attached. > > > > It's a good start for a cleanup, but there's no point in removing > > the boolean_t from one file and then not removing it from the rest > > of the XFS code. It's only used in a handful of places, so just > > remove it completely. > > > Done. > > Please, take another look. > > > Also, can you please place patches in line rather than attaching > > them. Attaching them means they cannot be quoted in reply. See > > Documentation/SubmittingPatches and Documentation/email-clients.txt > > for guidelines. > > > Sorry, patch attached. It's still attached as a base64 encoded attachment, not as inline text.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
