Hey Eric, On Thu, Nov 01, 2012 at 11:35:54PM -0500, Eric Sandeen wrote: > On 10/31/12 2:46 PM, Ben Myers wrote: > > Hi Eric, > > ... > > > It seemed like it could be an important bugfix but I wasn't really sure so I > > asked. Since it sounds like it's not a big deal, lets just hold off till after > > the release... > > Well, I was wrong - at least at one point, I thought it was getting zeroed. (?!) > > But Dave was running into trouble tonight ... > > And as the git tree stands today, I'm getting checksum errors w/o this patch > too, and xfstests dump group is passing only with it added back in. Interesting! It works great as-is on i386. ;) I gave it a spin on an x86_64 box and now I see the errors too. > So I think you'd better pull it in, maybe change the commit message a bit > though - it downplays the importance too much I guess. I'll add something like: This fixes 'bad header checksum' errors in xfsrestore, which were introduced by commit 1e309da7. > Sorry about that, No problem. It worked out fine. ;) Thanks, Ben _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs