Re: [PATCH 24/23] xfs: convert buffer verifiers to an ops structure.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 18, 2012 at 03:50:28PM +1100, Dave Chinner wrote:
> Here's a patch that does this. It adds on top of the series, and
> points out more changes needed to growfs to support CRC checking
> properly.

I like this a lot, and I'm fine with having this at the end of the
series if it makes your life easier.

> -xfs_agfl_write_verify(
> +xfs_agfl_read_verify(
>  	struct xfs_buf	*bp)
>  {
>  	xfs_agfl_verify(bp);
>  }
>  
>  static void
> -xfs_agfl_read_verify(
> +xfs_agfl_write_verify(
>  	struct xfs_buf	*bp)
>  {
>  	xfs_agfl_verify(bp);
> -	bp->b_pre_io = xfs_agfl_write_verify;
> -	bp->b_iodone = NULL;
> -	xfs_buf_ioend(bp, 0);
>  }

Any good reason to keep all these no-op wrappers?

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux