Re: [PATCH 2/2] 251: Do not allow step to be zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 16, 2012 at 11:41:34AM +0200, Lukas Czerner wrote:
> Currently 'step' variable which is used as length of the range to
> discard can be zero. However it would result in error returned by the
> fstrim.
> 
> Fix this by forcing 'step' to be at least 4KB.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Looks fine. It may not be perfect for large block filesystems (e.g.
on ppc or ia64) but it's better than nothing right now.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux