On Thu, Oct 11, 2012 at 05:44:21PM -0400, Christoph Hellwig wrote: > On Tue, Oct 09, 2012 at 02:50:58PM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Add an AGFL block verify callback function and pass it into the > > buffer read functions. Add a debug only check for valid block > > numbers in the AGFL. > > The check isn't executed only for debug builds, but rather all > the time. I'm not sure that this actually is a good idea. RIght, I need to update the commit message to indicate that the debug only checks are being made unconditional. That is, we're going to detect the AGFL being invalid on production systems now. Realistically, I'd much prefer that we have more robust verification of on-disk structures when we pull them into memory regardless of CRC functionality. We don't verify the AGFL at all, and given that it generally stays resident in memory, a small amount of iextra overhead when they are read isn't going to be noticable. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
