On Tue, Oct 09, 2012 at 02:50:53PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Rather than have to detect if the buffer has just been read from > disk by futzing with buffer state, supply the read functions with a > verification callback and attach that to the buffer to be run if the > buffer has to be read from disk into memory. > > If the verify function fails, then the buffer will be marked with an > EFSCORRUPTED error to indicate that the buffer did not pass > verification and should be considered tainted. The commit message seems to be a bit confusing for a patch that does nothing but adding a function pointer to the read functions which isn't set yet. I suspect it should have a description what's actually going on just in this patch as well, and just mention the above as the purpose for it. Otherwise looks fine, Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs