On Tue, Sep 25, 2012 at 09:24:15AM -0500, Mark Tinguely wrote:
> The vector feature of xfs_io uses its own memory buffer in the iov structure
> and does not use the buffer entry. Remove the duplicate memalign.
>
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
> ---
> io/pread.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: b/io/pread.c
> ===================================================================
> --- a/io/pread.c
> +++ b/io/pread.c
> @@ -76,8 +76,7 @@ alloc_iovec(
> buffersize = 0;
> for (i = 0; i < vectors; i++) {
> iov[i].iov_base = memalign(pagesize, bsize);
> - buffer = memalign(pagesize, bsize);
> - if (!buffer) {
> + if (!iov[i].iov_base) {
> perror("memalign");
> goto unwind;
> }
Classic copy'n'paste bug. My fault.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
