On Thu, Sep 6, 2012 at 1:04 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Wed, Sep 05, 2012 at 02:00:35PM +0200, Boris Ranto wrote: >> On Thu, 2012-07-26 at 19:28 +1000, Dave Chinner wrote: >> > From: Dave Chinner <dchinner@xxxxxxxxxx> >> > >> > Essentially the change is simply this. Converting: >> > >> > ... >> $seq.???? >> > >> > to: >> > >> > .... >> $RESULT_DIR/$seq.???? >> > >> > so that output files are directed to the defined output directory. >> > >> > sed to the rescue: >> > >> > $ sed -i -e '/^seq=.*$/a seqres=$RESULT_DIR/$seq' -e 's/seq.full/seqres.full/' tests/*/* >> > >> > will do most of the work automatically. > ..... >> Quite a lot of tests use $here/$seq.full. This results in >> $here/$seqres.full after the sed. $seqres is just a $RESULT_DIR/$seq. >> This would break if RESULT_DIR was set to an absolute path instead of >> relative path. > > Yes. As the patch description says it "will do most of the work", > but it doesn't do all of it. Indeed, supporting full paths for > $RESULT_DIR is actually necessary for other reasons, such as > supporting completely external result destinations. To that end, I > have a patch in my current series that does the rest of the > conversion with the appropriate setup changes: > > commit 08dbbb1e6a82a4ed04e0622b7ee63957fae7721b > Author: Dave Chinner <dchinner@xxxxxxxxxx> > Date: Wed Aug 22 16:09:33 2012 +1000 > > xfstests: RESULTS_DIR needs to be an absolute path > > > Some tests 'cd <somedir>' and then direct output to $RESULT_DIR, > which fails if the current working directory is not $here. > Regardless, if an external results directory is to be used it needs > to have a full path specified and the use of $here as the base of > the results files is completely incorrect. > > Hence change all the $here/$seqres* references to simply be > $seqres*, and instead encode the full path to the results in > $RESULT_DIR. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs OK, I just wanted to report the issue. btw: The installation does not seem to work with the posted patches (it expects the old '[0-9]??' tests to be in the root directory of xfstests). Do you have/work on any patch for that? Regards, Boris _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
