Hey Rich, On Tue, Aug 28, 2012 at 12:26:05PM -0500, Rich Johnston wrote: > This 5 part patchset (for xfstests, dmapi and xfsdump): > > 1. Uses libtool to install the binary from the proper location and display a > warning if any shared library dependancies are not properly installed. > 2. Ensures that a libtool wrapper shell script is not installed in place of > the application when libtool wrappers are being used. > 3. Removes the undocumented feature which allowed xfs developers to build and > run xfstests without having to install the libraries. This can lead to > touble if you expect that xfstests is using the versions of the libraries > installed on the system. This patchset looks great to me. Although Dave has mentioned that the first patch probably isn't strictly necessary... I think that it's worth pulling in. Since we build with libtool we should also install with libtool. Dave also asked about dmapi. I took a brief look at the dmapi Makefiles. It appears the library is already installed using INSTALL_LTLIB. Looks good! Reviewed-by: Ben Myers <bpm@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
