Re: [PATCH] xfsdump: save & restore 32-bit projids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 26, 2012 at 07:20:07PM -0500, Eric Sandeen wrote:
> Current xfsdump/xfsrestore only recognize the lower 16 bits of the projid.
> With this patch, the full 32 bits are dumped & restored.
> 
> Reported-by: Boris Ranto <branto@xxxxxxxxxx>
> Cc: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> This also adds a definition for bs_forkoff, but I don't think
> that is something which should get saved & restored, correct?

Right - it's a kernel controlled field, only exported as a hint to
help xfs_fsr build similarly formatted inodes.

> TBH I've done very little hacking on xfsdump.  I think this
> requires a new version, but not sure.  This seems to work but
> may need sanity checks & fixups.  And, of course, an xfstest.

Looks ok, but I'm in the same boat as you on xfsdump. A QA test
would be good to go along with this. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux