Hello, I was looking into why test 272 from xfstests fails for ext3 and the reason is that ext3 does not support direct IO to file with enabled data journalling (open returns EINVAL because ->direct_IO callback is not specified). So I was thinking how to accomodate this fact in the test - the best I found was to just check using xfs_io whether O_DIRECT open succeeds and perform the test only in that case. Attached patch does this or do people have other ideas? Honza PS: Sending again with correct list address. I'm sorry for unnecessary email. -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR
>From 529429c8497314ef956e470fdb9b94bfe797df69 Mon Sep 17 00:00:00 2001 From: Jan Kara <jack@xxxxxxx> Date: Thu, 16 Aug 2012 11:14:35 +0200 Subject: [PATCH] Make test 272 work for ext3 ext3 does not support direct IO for files with data journalling. This confuses test 272. Make the test check whether open succeeds and perform the writing only if it does. Signed-off-by: Jan Kara <jack@xxxxxxx> --- 272 | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/272 b/272 index 26dfa3b..e39c52b 100755 --- a/272 +++ b/272 @@ -52,6 +52,12 @@ _workout() echo "OP write_opt: $write_opt 4M, \ chattr_opt: $chattr_opt" + if [ "$write_opt" = "oflag=direct" ]; then + # Some filesystems don't support direct IO + # in some cases, check for that + xfs_io -F -d -f -c "" $SCRATCH_MNT/file.$idx \ + >> $seq.full 2>&1 || continue + fi dd if=/dev/zero of=$SCRATCH_MNT/file.$idx \ bs=1M count=4 $write_opt \ >> $seq.full 2>&1 || exit -- 1.7.1
_______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
