On Tue, Aug 14, 2012 at 11:40:01AM +0200, Tomas Racek wrote: > Local version of fstrim was dropped so that we depend on upstream > version now. _require_fstrim was added to check if fstrim is available > in the system and _test_batched_discard to check if we can run fstrim > on certain mountpoint. > > Also tests 251 and 260 were modified to reflect this change. Looks OK, but the only thing I'd suggest is using a $FSTRIM_PROG variable rather than fsttrim directly. see how $XFS_IO_PROG is set up in common.rc and copy that. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
