On Mon, Jul 02, 2012 at 09:51:08AM -0400, Brian Foster wrote: > Right... if we wanted to move this back into xfsaild_push(), the only > way I can see doing that correctly is to move the task state logic down > into that function as well, at which point the idle logic is now spread > across two functions. :/ > > Considering this patch introduces an independent check for the idle > logic from the timeout logic (i.e., we use xfs_ail_min() now instead of > the general scan state of xfsaild_push()), I personally find the > separation of idle from timeout to be a bit more clear, but of course > I'll try to implement whatever is most agreeable... Let's take the patch as-is for 3.6 as we have enough other work in that area queued. We can clean it up later if needed. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs