Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 04, 2012 at 06:32:34PM +1000, Dave Chinner wrote:
> IMO, using uncached buffers in transactions is dangerous because
> concurrent transactions can't find buffers uncached buffers at the
> same address and so such buffers need higher level synchronisation
> interfaces (as the superblock has).
> 
> I'm happy to leave the superblock as uncached and work around it in
> some way, but it just seems wrong to me to have one buffer behaves
> differently to all the cached and other uncached buffers in the
> system. It doesn't sit well in my mind to do that when the problem
> simply goes away if we make the superblock a cached buffer again....

The superblock buffer always has been more special than others, remember
the old FS_MANAGED flag before we went for uncached buffers?

If you want to move it back to normal buffers how do you want to look
it up, given that IIRC we read it before setting up the perag buffers.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux