On 06/28/2012 01:44 AM, Christoph Hellwig wrote: > On Thu, Jun 28, 2012 at 12:57:23AM +0800, Wanlong Gao wrote: >> remove the mount options macro, use tokens instead. >> Futher cleanup will use xfs_*_opt in xfs instead, >> but it may be hard to be merged in one patch. > > Thanks a lot! > > I like the use of the option parse a lot, this has been long overdue. > > But is there any good reason to add the xfs_*_opt macros? They make > reading and especially grepping the code a lot harder, so there better > be a good reason for them. I think that using the macro makes code more clearly, and it's more convenient to use the macro than the original "|=", "&=" and "&" things. And, no more harder for reading and grepping, just omit the "XFS_MOUNT_". BTW, these macros were borrowed from Btrfs. I myself like it, but if you XFS guys all do not like, I can drop it. Thanks, Wanlong Gao > > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
