Hi,
comments inlined below
> @@ -1571,19 +1569,16 @@ xfs_log_sbcount(xfs_mount_t *mp)
> * counters on every modification.
> */
> if (!xfs_sb_version_haslazysbcount(&mp->m_sb))
> - return 0;
> + return 0;
^^^
I'd like to point this cosmetic thing about properly alignment of the
statement with its parent if condition.
>
> ===================================================================
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -371,7 +371,9 @@ typedef struct xfs_mod_sb {
> int64_t msb_delta; /* Change to make to specified field */
> } xfs_mod_sb_t;
>
> -extern int xfs_log_sbcount(xfs_mount_t *);
> +extern int
> +xfs_write_sbcount(
> + struct xfs_mount *mp);
I would also write it in one single line, but this is just my point of view
Otherwise, looks good
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
--
--Carlos
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
