Re: [PATCH 5/7] xfs: refactor xfs_ialloc_ag_select

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 05, 2012 at 10:46:52AM -0400, Christoph Hellwig wrote:
> Loop over the in-core perag structures and prefer using pagi_freecount over
> going out to the AGI buffer where possible.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. One minor thing:

> @@ -901,13 +897,13 @@ xfs_dialloc(
>  	xfs_buf_t	**IO_agbp,	/* in/out ag header's buffer */
>  	xfs_ino_t	*inop)		/* inode number allocated */
>  {
> +	xfs_mount_t	*mp = tp->t_mountp;

struct xfs_mount

Otherwise,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux