On Tue 12-06-12 10:23:47, Christoph Hellwig wrote: > > + * We will pass freeze protection with a transaction. So tell lockdep > > + * we released it. > > + */ > > + rwsem_release(&ioend->io_inode->i_sb->s_writers.lock_map[SB_FREEZE_FS-1], > > + 1, _THIS_IP_); > > I'll need some time to get through the whole series, but repeated use > of constructs like this really screams for a helper abstracting it out > and documenting it. It's there twice and only in XFS because XFS needs to pass the freeze protection (along with a transaction) to a worker thread. I'm not against a helper but then it should probably be in a form to allow easy instrumentation of lockdep that we are passing a state of lock together with a work struct? Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
