The patch looks good to me. I wonder if we should write the zeroes to disk directly instead of the buffer cache. In the end it's probably that no one uses the interfaces and cares anyway. Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs