On Tue, Apr 10, 2012 at 10:00:18AM -0500, Mark Tinguely wrote: > On 04/10/12 05:03, Dave Chinner wrote: > >From: Dave Chinner<dchinner@xxxxxxxxxx> > > > >Buffers are always returned locked from the lookup routines. Hence > >we don't need to tell the lookup routines to return locked buffers, > >on to try and lock them. Remove XBF_LOCK from all the callers and > >from internal buffer cache usage. ..... > >-no_buffer: > >- if (flags& (XBF_LOCK | XBF_TRYLOCK)) > >- xfs_buf_unlock(bp); > >- xfs_buf_rele(bp); > >- return NULL; > > } > > > Do you have a new copy of the "xfs: fix buffer lookup race on > allocation failure" patch. It would go about here in the sources. > > The reason I ask, the sources that I have for xfs_buf_get() seems to > still have a "goto no_buffer" for the failed > xfs_buf_allocate_memory() call and this patch removes that call. I > did not find anything in the 8 buf clean-up series that would alter > this area. I'm sure I posted it previously. Let me update all the reviewed-by tags and I'll resend the entire series.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
