On Sun, Mar 25, 2012 at 09:46:49AM +1100, Dave Chinner wrote: > > Looks good. I wonder if it might be simple to simply pass a flags > > argument to xfs_ail_delete(_bulk) which tells which kind of shutdown > > to do. > > I thought about doing that, but it seems strange and unusual to tell > code how to handle errors internally instead of returning the error > and letting the caller handle it... > > I don't mind either way, though. If you prefer I pass in the > shutdown flag, I can change it all to do that.... I don't have a strong opinion. Moving the shutdown to the caller is cleaner for sure, but it's a lot of churn when the other version would _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
