Re: [PATCH 3/4] xfs: allow assigning the tail lsn with the AIL lock held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 22, 2012 at 10:29:56AM +1100, Dave Chinner wrote:
> On Fri, Mar 16, 2012 at 01:55:44PM -0400, Christoph Hellwig wrote:
> > Provide a variant of xlog_assign_tail_lsn that has the AIL lock already
> > held.  By doing so we do an additional atomic_read + atomic_set under
> > the lock, which comes down to two instructions.
> > 
> > Switch xfs_trans_ail_update_bulk and xfs_trans_ail_delete_bulk to the
> > new version to reduce the number of lock roundtrips, and prepare for
> > a new addition that would require a third lock roundtrip in
> > xfs_trans_ail_delete_bulk.
> 
> What new addition is that? I don't see it in this patchset (maybe
> I'm just blind), so maybe this isn't necessary in the commit
> message?

The check for an empty AIL before waking up thread thread waiting for
it.  I'll add it to the commit log.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux