On Wed, Mar 14, 2012 at 08:54:09AM +1100, Dave Chinner wrote: > On Tue, Mar 13, 2012 at 03:03:54PM -0500, Ben Myers wrote: > > On Tue, Mar 13, 2012 at 04:52:36AM -0400, Christoph Hellwig wrote: > > > + struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH]; > > > > Eesh.. that probably doesn't need to go onto the stack. I know we are > > doing it elsewhere too, and that we also sometimes complain about other > > peoples' stack usage. Don't necessarily have to clean it up now, > > though. ;) > > Actually, if we do the walk from the shrinker we can't reliably > allocate it, so it has to go on the stack. D'oh, I missed that idea completely in my review. :/ _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
