On 03/08/12 16:37, Eric Sandeen wrote:
On 3/8/12 4:37 PM, Mark Tinguely wrote:
On 03/08/12 16:20, Eric Sandeen wrote:
Now that -F ("foreign") is automagic, we should no longer list
it in the help output for open, but we should still accept
it for compatibility; esp. as it is still in the case statement.
Oops.
Reported-by: Mark Tinguely<tinguely@xxxxxxx>
Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---
diff --git a/io/open.c b/io/open.c
index ac39ccc..46538ba 100644
--- a/io/open.c
+++ b/io/open.c
@@ -240,7 +240,6 @@ open_help(void)
"\n"
" Opens a file for subsequent use by all of the other xfs_io commands.\n"
" With no arguments, open uses the stat command to show the current file.\n"
-" -F -- foreign filesystem file, disallow XFS-specific commands\n"
" -a -- open with the O_APPEND flag (append-only mode)\n"
" -d -- open with O_DIRECT (non-buffered IO, note alignment constraints)\n"
" -f -- open with O_CREAT (create the file if it doesn't exist)\n"
@@ -274,7 +273,7 @@ open_f(
return 0;
}
- while ((c = getopt(argc, argv, "Racdfm:nrstx")) != EOF) {
+ while ((c = getopt(argc, argv, "FRacdfm:nrstx")) != EOF) {
switch (c) {
case 'F':
/* Ignored / deprecated now, handled automatically */
Thank-you. Probably could take it out of the man page under the open I/O command now too.
Gah. With your blessing I'll commit that as well?
Reviewed-by: Mark Tinguely
Yes, and I should have saw it before too. Good idea to remove the flag.
--Mark Tinguely
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
