On Fri, Mar 02, 2012 at 02:51:04AM -0500, Christoph Hellwig wrote: > Hmm, I don't like this complication all that much. Though it is a simple, self contained fix for the problem... > Why would we even bother caching inodes during quotacheck? The bulkstat > is a 100% sequential read only workload going through all inodes in the > filesystem. I think we should simply not cache any inodes while in > quotacheck. I have tried that approach previously with inodes read through bulkstat, but I couldn't find a clean workable solution. It kept getting rather complex because all our caching and recycling is tied into VFS level triggers. That was a while back, so maybe there is a simpler solution that I missed in attempting to do this. I suspect for a quotacheck only solution we can hack a check into .drop_inode, but a generic coherent non-cached bulkstat lookup is somewhat more troublesome. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
