On Wed, Feb 15, 2012 at 10:31:43AM -0200, Carlos Maiolino wrote: > I would change a little this sentence, looks a little confusing at least for me. > How about: > > /* If we found an entry based on the device name, make sure we > * stat the mount point given by mtab and ensure it's accessible > * before using it. > */ Agreed, I'll redo it. > > + if (S_ISLNK(sb.st_mode)) { > > + struct stat64 sb2; > > Particularly, I don't like variable declarations between statements, but I'm not > too experienced to say what's good or not :) The idea is to keep variable declarations as local as possible. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs