On Tue, Feb 14, 2012 at 09:29:30PM -0500, Christoph Hellwig wrote:
> Use the same per-CPU scheme used in the main XFS statistics, as well as
> the VFS inode and dcache statistics for the quota code.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
.....
> -struct xqmstats xqmstats;
> +DEFINE_PER_CPU(struct xqmstats, xqmstats);
> +
> +static int xqmstats_sum(int idx)
> +{
> + int val = 0, cpu;
> +
> + for_each_possible_cpu(cpu)
> + val += *(((__u32 *)&per_cpu(xqmstats, cpu) + idx));
> + return max(val, 0);
> +}
Why not just make val a 64bit value so overflow is simply not an
issue?
Otherwise, all looks good.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
