On 02/12/2012 05:47 PM, Christoph Hellwig wrote:
Looks generally good to me, but is there any good reason to not make the -K argument extensible by requiring a version argument, even if that one currently only supports 2 and 3 as valid values?
I thought about doing that, but given the low frequency of format changes decided it could wait until there's more than one old format to support. -K without an argument could be treated as "generate the previous media format", or with an argument it could generate a specific format. I'm okay with requiring a version argument though, being explicit is better. FWIW, the way things have always worked is that xfsrestore provides backwards compatibility for all dump formats. xfsdump has, until now, always generated the current format. It's nice to provide the ability to generate old formats during a transition period, but long-term I don't see xfsdump retaining support for generating all old formats. Bill _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
