On 02/06/2012 08:11 PM, Christoph Hellwig wrote: > On Mon, Feb 06, 2012 at 04:27:49PM +0800, Liu Bo wrote: >> +_runtest() >> +{ >> + $progs_dir/runtest.sh $defrag_args $SCRATCH_MNT $SCRATCH_DEV > > please put the actual tests into test cases themselves instead of > calling out into shell scripts under src. If you have common code > shared between multiple tests please put them into common.defrag. > I see, will update it. >> + >> +# get standard environment, filters and checks >> +. ./common.rc >> +. ./common.filter >> +. ./common.defrag >> + >> +# real QA test starts here >> +_supported_fs xfs btrfs > > does it really support xfs? > sorry, my miss. Thanks for reviewing! thanks, liubo > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs