On Mon 06-02-12 11:20:29, Jeff Moyer wrote: > Jan Kara <jack@xxxxxxx> writes: > > >> + /* workqueue for aio+dio+o_sync disk cache flushing */ > >> + struct workqueue_struct *aio_dio_flush_wq; > >> + > > Hmm, looking at the patch I'm wondering why did you introduce the new > > workqueue? It seems dio_unwritten_wq would be enough? You just need to > > rename it to something more appropriate ;) > > I used a new workqueue as the operations are blocking, and I didn't want > to hold up other progress. If you think re-using the unwritten_wq is > the right thing to do, I'm happy to comply. Ah, ok. Thinking about it, it's probably better to use a separate work queue then. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
