On Thu 02-02-12 11:14:12, Christoph Hellwig wrote: > Now that XFS takes quota reservations into account there is no need to flush > anything before reporting quotas - in addition to beeing fully transactional > all quota information is also 100% coherent with the rest of the filesystem > now. Looks fine. You can add: Acked-by: Jan Kara <jack@xxxxxxx> Honza > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Index: xfs/fs/quota/quota.c > =================================================================== > --- xfs.orig/fs/quota/quota.c 2012-02-02 13:06:30.693396524 +0100 > +++ xfs/fs/quota/quota.c 2012-02-02 13:23:23.181244741 +0100 > @@ -282,10 +282,9 @@ static int do_quotactl(struct super_bloc > case Q_XGETQUOTA: > return quota_getxquota(sb, type, id, addr); > case Q_XQUOTASYNC: > - /* caller already holds s_umount */ > if (sb->s_flags & MS_RDONLY) > return -EROFS; > - writeback_inodes_sb(sb, WB_REASON_SYNC); > + /* XFS quotas are fully coherent now, making this call a noop */ > return 0; > default: > return -EINVAL; > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
