On Fri, Jan 27, 2012 at 03:37:26PM +0900, Mitsuo Hayasaka wrote: > The kmem_realloc() in xfs is given KM_* memory allocation flags. And it > allocates memory using kmalloc() after they are converted to gfp_mask > flags. In xlog_recover_add_to_cont_trans(), 0u is passed to kmem_realloc(), > instead of them. I guess it is preferred to use them, and here memory must > be allocated but don't have to be done with GFP_ATOMIC. So, this patch > changes it to KM_SLEEP. Looks good. I actually just noticed it when changing the kmem_realloc implementation, but let's put your patch in before that and send it off to Linus ASAP. Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs