On Tue, Jan 17, 2012 at 12:48:10PM -0600, Mark Tinguely wrote: > On 01/-10/63 13:59, Christoph Hellwig wrote: > >Currently xfs_log_move_tail has a tail_lsn argument that is horribly > >overloaded: it may contain either an actual lsn to assign to the log tail, > >0 as a special case to use the last sync LSN, or 1 to indicate that no tail > >LSN assignment should be performed, and we should opportunisticly wake up > >at least one task waiting for log space. > > I read the code as opportunistically waking at MOST one task per call. I guess my wording wasn't quite clear - the opportunistic flag makes sure at least one task is woken per call, but at most one of them wouldn't otherwise be woken. > Looks great. Just to be consistent, you could call the above as: > > + xfs_log_space_wake(ailp->xa_mount, true); Indeed. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
