Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
> When a system tries to mount a filesystem (FS) using UUID, the xfs
> returns -EINVAL and shows a message if a FS with the same UUID has
> been already mounted. It is useful to output the duplicate UUID
> with it.

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> -	xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
> +	xfs_warn(mp,
> +		"Filesystem has duplicate UUID - can't mount: uuid = %pU",
> +		uuid);

Maybe we could write this a bit nicer as:

	xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux