Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 20, 2011 at 10:36:38PM -0600, Ben Myers wrote:
> On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > When finding the longest extent in an AG, we read the value directly
> > out of the AGF buffer without endian conversion. This will give an
> > incorrect length, resulting in FITRIM operations potentially not
> > trimming everything that it should.
> 
> Looks good to me.
> 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

This is a pretty serious thing, can you send it to Linus as soon as
he takes the current pull request?

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux