On Fri, Dec 23, 2011 at 03:47:03PM -0600, Ben Myers wrote: > > Reviewed-by: Ben Myers <bpm@xxxxxxx> > > Mark also reviewed this. > > Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> Just a process note here: if Mark reviewed the code and is happy with it, then he needs to send his reviewed-by tag himself. If he's got concerns, then he needs to discuss them on the list with the patch author, not just in private with you. If a person's questions are not posted to the mailing list or posted by proxy and they didn't aprticipate in discussions on the list, then there is no evidence that the person ever reviewed the patch. Hence the tag has no value because it is not verifiable. More importantly, tags are a semi-formal statement that a set of actions has been taken by that person - see Documentation/SubmittingPatches for the actions different tags imply. Hence it is important the actions they imply are verifiable, and it also reinforces the fact that they only have value when they are issued by the email address (or a known alias) in the tag.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
