Re: [patch 07/19] xfs: remove the sync_mode argument to xfs_qm_dqflush_all

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 06, 2011 at 04:58:13PM -0500, Christoph Hellwig wrote:
> It always is zero, and removing it will make future changes easier.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good
Reviewed-by: Ben Myers <bpm@xxxxxxx>

> ---
>  fs/xfs/xfs_qm.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Index: xfs/fs/xfs/xfs_qm.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_qm.c	2011-11-25 11:45:37.468716258 +0100
> +++ xfs/fs/xfs/xfs_qm.c	2011-11-25 11:45:39.375372594 +0100
> @@ -415,8 +415,7 @@ xfs_qm_unmount_quotas(
>   */
>  STATIC int
>  xfs_qm_dqflush_all(
> -	struct xfs_mount	*mp,
> -	int			sync_mode)
> +	struct xfs_mount	*mp)
>  {
>  	struct xfs_quotainfo	*q = mp->m_quotainfo;
>  	int			recl;
> @@ -451,7 +450,7 @@ again:
>  		 * across a disk write.
>  		 */
>  		mutex_unlock(&q->qi_dqlist_lock);
> -		error = xfs_qm_dqflush(dqp, sync_mode);
> +		error = xfs_qm_dqflush(dqp, 0);
>  		xfs_dqunlock(dqp);
>  		if (error)
>  			return error;
> @@ -1567,7 +1566,7 @@ xfs_qm_quotacheck(
>  	 * successfully.
>  	 */
>  	if (!error)
> -		error = xfs_qm_dqflush_all(mp, 0);
> +		error = xfs_qm_dqflush_all(mp);
>  
>  	/*
>  	 * We can get this error if we couldn't do a dquot allocation inside
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux