_require_user only checks if the qa user exists in /etc/passwd. It may exist
though still not be able to execute anything (e.g. with a /bin/false shell).
_user_do cannot determine failure to execute the given command, as it uses
_user_do_filter for post-processing which succeeds even if the command
fails. Thus, the check should be performed by _require_user.
Signed-off-by: Jan Schmidt <list.btrfs@xxxxxxxxxxxxx>
---
common.rc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/common.rc b/common.rc
index cab0b64..f540a79 100644
--- a/common.rc
+++ b/common.rc
@@ -897,6 +897,8 @@ _require_user()
qa_user=fsgqa
_cat_passwd | grep -q $qa_user
[ "$?" == "0" ] || _notrun "$qa_user user not defined."
+ echo /bin/true | su $qa_user
+ [ "$?" == "0" ] || _notrun "$qa_user cannot execute commands."
}
_filter_user_do()
--
1.7.2.2
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
