On Mon, Dec 05, 2011 at 02:55:16PM +1100, Dave Chinner wrote: > > + * > > + * Note that this format differs from the old log vector format in that there > > + * is no transaction header in these log vectors. > > Do we even need this comment given the old itransaction commit code > that did this is now gone? We could probably drop this, yes. > Would it make sense to have IOP_FORMAT return the length of the > vectors (calculated as itis built) rather than having to add them up > after the fact? That would avoid an extra pass across the vector > array. Regardless, it can be done as a future patch... I have a WIP patch for that, but it's not quite ready yet. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
