On Thu, Nov 03, 2011 at 03:29:18PM +0530, Amit Sahrawat wrote: > > You probably should keep the original Signoff and reviewed-by tags, > > and add your editor note on the top into [ ] ?brackets. > Ok, will do so in the final patch. Actually was unaware of information > to keep in backported patches? The standard procedure is to keep patches basically as-is. This doesn't quite apply for your case, so I think just adding a comment in [ ] brackets on the top is the best you can do. > > You also need to make the i_mutex unlock and need_i_mutex update > > conditional here, otherwise you still serialize all O_DIRECT writes. > > > you mean, keeping need_i_mutex=0 and mutex_unlock as part of 'else' statement. Yes. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs